[prev in list] [next in list] [prev in thread] [next in thread] 

List:       linux-ext4
Subject:    Re: [PATCH] filefrag: avoid temporary buffer overflow
From:       Theodore Ts'o <tytso () mit ! edu>
Date:       2018-03-03 18:47:12
Message-ID: 20180303184712.GA26224 () thunk ! org
[Download RAW message or body]

On Fri, Mar 02, 2018 at 09:48:28AM -0800, Darrick J. Wong wrote:
> On Thu, Mar 01, 2018 at 01:09:46PM -0700, Andreas Dilger wrote:
> > From: Andreas Dilger <adilger@dilger.ca>
> > 
> > If an unknown flag is present in a FIEMAP extent, it is printed as a
> > hex value into a temporary buffer before adding it to the flags.  If
> > that unknown flag is over 0xffff then it will overflow the temporary
> > buffer.
> > 
> > Reported-by: Sarah Liu <wei3.liu@intel.com>
> > Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-10335
> > Signed-off-by: Andreas Dilger <andreas.dilger@intel.com>
> 
> Looks ok,
> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

Thanks, applied with the 0xfff fixup in the commit description.

		     	       	     - Ted
[prev in list] [next in list] [prev in thread] [next in thread]