[prev in list] [next in list] [prev in thread] [next in thread] 

List:       git-commits-head
Subject:    staging: lustre: info leak in lnet_ping()
From:       "Linux Kernel Mailing List" <linux-kernel () vger ! kernel ! org>
Date:       2014-06-08 18:57:40
Message-ID: 20140608185740.0FFC46617C2 () gitolite ! kernel ! org
[Download RAW message or body]

Gitweb:     http://git.kernel.org/linus/;a=commit;h=751a624adbe47145d3667c4b504858ffd3e8f175
Commit:     751a624adbe47145d3667c4b504858ffd3e8f175
Parent:     fea0683ebe7f642528c186109f928f9467e0c37e
Refname:    refs/heads/master
Author:     Dan Carpenter <dan.carpenter@oracle.com>
AuthorDate: Sat May 3 23:23:29 2014 +0300
Committer:  Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CommitDate: Fri May 16 16:10:41 2014 -0700

    staging: lustre: info leak in lnet_ping()
    
    On 64 bit systems there is a 4 byte hole after the last member of the
    struct.  We should clear it to avoid disclosing stack information.
    
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 drivers/staging/lustre/lnet/lnet/api-ni.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/staging/lustre/lnet/lnet/api-ni.c b/drivers/staging/lustre/lnet/lnet/api-ni.c
index 3f1fdaa..3f878de 100644
--- a/drivers/staging/lustre/lnet/lnet/api-ni.c
+++ b/drivers/staging/lustre/lnet/lnet/api-ni.c
@@ -1927,6 +1927,7 @@ lnet_ping (lnet_process_id_t id, int timeout_ms, lnet_process_id_t *ids, int n_i
 
 	rc = -EFAULT;			   /* If I SEGV... */
 
+	memset(&tmpid, 0, sizeof(tmpid));
 	for (i = 0; i < n_ids; i++) {
 		tmpid.pid = info->pi_pid;
 		tmpid.nid = info->pi_ni[i].ns_nid;
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]